Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tile() and slidingWindows() now preserve names #3

Merged
merged 2 commits into from
Mar 23, 2018
Merged

tile() and slidingWindows() now preserve names #3

merged 2 commits into from
Mar 23, 2018

Conversation

PeteHaitch
Copy link
Contributor

This would've been useful to me the other day. Might help others, too

@hpages
Copy link
Contributor

hpages commented Feb 23, 2018

I'll let @lawremi take care of this one.

Heads-up: I'm not terribly happy with the current proliferation of "tiling tools" (successiveIRanges(), successiveViews(), tileGenome(), tile(), slidingWindows(), and maybe more...) with more or less overlap between them (see my comment at the top of https://github.com/Bioconductor/IRanges/blob/master/R/tile-methods.R). This will need to be revisited at some point.

H.

@PeteHaitch
Copy link
Contributor Author

PeteHaitch commented Feb 23, 2018 via email

@mtmorgan
Copy link

@lawremi I'm not sure if you want to incorporate this patch or close the issue?

@lawremi
Copy link
Collaborator

lawremi commented Mar 23, 2018

Sorry I just missed this.

@lawremi lawremi merged commit f6e6f4c into Bioconductor:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants