Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Factor class #38

Closed
hpages opened this issue May 31, 2019 · 4 comments
Closed

Add Factor class #38

hpages opened this issue May 31, 2019 · 4 comments

Comments

@hpages
Copy link
Contributor

hpages commented May 31, 2019

A generalization of factor objects where the levels can be any vector-like object

As discussed here: Bioconductor/Contributions#1114
This was referenced May 31, 2019
Closed
Closed
@LTLA
Copy link
Contributor

LTLA commented May 31, 2019

Should I PR in some code from IndexedRelations? Most of the underlying machinery is already there, along with the docs and tests.

@hpages
Copy link
Contributor Author

hpages commented May 31, 2019

Thanks for offering but it should not be necessary. Already started to work on this...

@hpages
Copy link
Contributor Author

hpages commented Jun 4, 2019

Done in S4Vectors 0.23.7. Please take a look and let me know how that works for you (report any problem in a new issue). Now will add GRangesFactor to GenomicRanges.

@hpages hpages closed this as completed Jun 4, 2019
@LTLA
Copy link
Contributor

LTLA commented Jun 5, 2019

Thanks Herve. The implementation matches up with what I was anticipating.

Looks like I'll archive IndexedRelations now. Alas! My thunder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LTLA @hpages