1.4.0 fails to build with Clang-16: error: expected 'match' clause on 'omp declare variant' directive

[barracuda156]

New version fails to build with Clang:

  /opt/local/bin/clang-mp-16 -I"/opt/local/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/opt/local/Library/Frameworks/R.framework/Versions/4.4/Resources/library/S4Vectors/include' -I'/opt/local/Library/Frameworks/R.framework/Versions/4.4/Resources/library/IRanges/include' -I'/opt/local/Library/Frameworks/R.framework/Versions/4.4/Resources/library/XVector/include' -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk   -fopenmp -fPIC  -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -arch arm64  -c thread_control.c -o thread_control.o
  In file included from thread_control.c:7:
  /opt/local/include/libomp/omp.h:494:39: error: expected 'match' clause on 'omp declare variant' directive
      #pragma omp begin declare variant match(device={kind(host)})
                                        ^
  /opt/local/Library/Frameworks/R.framework/Resources/include/Rinternals.h:984:17: note: expanded from macro 'match'
  #define match                   Rf_match
                                  ^
  In file included from thread_control.c:7:
  /opt/local/include/libomp/omp.h:497:39: error: expected 'match' clause on 'omp declare variant' directive
      #pragma omp begin declare variant match(device={kind(nohost)})
                                        ^
  /opt/local/Library/Frameworks/R.framework/Resources/include/Rinternals.h:984:17: note: expanded from macro 'match'
  #define match                   Rf_match
                                  ^
  2 errors generated.
  make: *** [thread_control.o] Error 1
  ERROR: compilation failed for package ‘SparseArray’
  * removing ‘/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_R_R-SparseArray/R-SparseArray/work/build/SparseArray’
  Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_R_R-SparseArray/R-SparseArray/work/SparseArray" && /opt/local/bin/R CMD INSTALL . --library=/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_R_R-SparseArray/R-SparseArray/work/build --install-tests 
  Error: Failed to build R-SparseArray: command execution failed

GCC build is fine.

[hpages]

Thanks for the report.

Hopefully adding the following line will do:

SparseArray/src/thread_control.c

Lines 7 to 10 in 533a86a

	/* <Rinternals.h> defines macro match that seems to break <omp.h> on
	some versions of Clang.
	See https://github.com/Bioconductor/SparseArray/issues/9 */
	#undef match

Unfortunately I don't have access to Clang-16 so was not able to test.

This is in SparseArray 1.5.2 (devel branch) and 1.4.2 (RELEASE_3_19 branch).

[hpages]

@barracuda156 Can you confirm the problem is gone with the latest version? Thanks