-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bioconductor/sweave2rmd: Conversion of howtogenefilter.Rnw to Rmd #11
Conversation
@Bioconductor/sweave2rmd please review my contribution for Outreachy. |
Hi @Khadeeejah, Thanks for your pull request. We're going to use the following checklist for the review, doing a little bit at a time:
|
@Khadeeejah Please address these changes. I believe some of them, such as the inline code or blank spaces may appear again later in the document. Please also address those. Push your changes to this PR and let me know we're ready to continue the review. |
@jwokaty thank you |
i also removed Maintainer: Bioconductor Package Maintainer <maintainer@bioconductor.org>
@jwokaty kindly review i have fixed all |
@Khadeeejah Can you please wrap long lines and check the correct syntax for code block names in the R Markdown cheatsheet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khadeeejah Hi, I have marked additional issues, which are mostly minor, but these should be the final issues addressed before we can merge. Although I have mentioned it in another comment, please wrap all long lines and correct the naming of code blocks (there should be no comma between the r
and the name of the code block.
@Khadeeejah Can I ask that you leave these unresolved? I will use them to recheck your code when you have pushed all your changes? |
Good morning ma @jwokaty i have updated my PR. |
vignettes/howtogenefilter.Rmd
Outdated
Here `f1` is a function that implies our "expression measure above 200 in at | ||
least 5 samples" criterion, the function `ffun` is the filtering function (which | ||
in this case consists of only one criterion), and we apply it using | ||
`r Biocpkg("genefilter")`. There were `r sum(wh1)` genes that satisfied the | ||
criterion and passed the filter. | ||
As an example for a specific filter, let us select genes that are differentially | ||
expressed in the groups defined by `type`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reformat lines 64-70 and 78-84?
Hi @Khadeeejah, I have 2 last changes to improve the formatting of 2 paragraphs. After you push the changes, provided that there are no new issues, I'll merge your PR. |
@jwokaty i have formatted the two paragraphs, thank you |
Thanks for your contribution! I'm merging your PR. |
Thank you so much please can you assign the last vignette on the board to me or any other I would love to contribute more |
@Bioconductor/sweave2rmd
My name is Khadijah an Outreachy applicant. I was assigned this issue on the project board,
@jwokaty Kindly review my PR.
HTML
PDF