Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropensityFeatureStandardization deepcopy fix #35

Merged
merged 2 commits into from
May 24, 2022
Merged

PropensityFeatureStandardization deepcopy fix #35

merged 2 commits into from
May 24, 2022

Commits on May 24, 2022

  1. Fix deepcopy fail in PropensityFeatureStandardization 

    removed calculating of feature functions on init
this makes the object un-deepcopyable.
the reason is that the set of feature functions store a copy of self
that does not get updated on deepcopy.
since the function is only called once, and it is a light function,
i opted to remove the attribute entirely and just create the dict
when it is needed. that way self will never be misreferenced.

Add deepcopy tests
    @mmdanziger @ehudkr
    mmdanziger authored and ehudkr committed May 24, 2022
    Configuration menu
    Copy the full SHA
    57b8032 View commit details
    Browse the repository at this point in the history

  2. Bump version: 0.8.2

    @ehudkr
    ehudkr committed May 24, 2022
    Configuration menu
    Copy the full SHA
    cc9269e View commit details
    Browse the repository at this point in the history