Add vit isic #221
Add vit isic #221
Conversation
shatz01
commented
Nov 23, 2022
shatz01
commented
- adds vit to isic
- makes vit default
- adds pl_func for clearml logger
- adds clearml logger to isic
…nto add_vit_isic
| @@ -208,6 +277,8 @@ def run_train(paths: dict, train_common_params: dict) -> None: | |||
| lgr.info("Datamodule:", {"attrs": "bold"}) | |||
|
|
|||
| datamodule = create_datamodule(paths, train_common_params) | |||
| # datamodule.setup(stage="fit") | |||
There was a problem hiding this comment.
removed here 8e9a212
| @@ -194,6 +261,8 @@ def run_train(paths: dict, train_common_params: dict) -> None: | |||
| # ============================================================================== | |||
| # Logger | |||
| # ============================================================================== | |||
| data_string = "multimodal" if multimodality else "imaging" | |||
| start_clearml_logger(project_name="SHATZ_isic_II", task_name=f"{model_type}_{data_string}") | |||
There was a problem hiding this comment.
change the project name to be an argument (set by default to None). Start clearml logger only if it's not None.
There was a problem hiding this comment.
Can you please explain how it knows the server address?
Is it a global configuration?
There was a problem hiding this comment.
yes you make a ~/clearml.conf file and specify server address. ill dm you more details
fuse/dl/lightning/pl_funcs.py
Outdated
|
|
||
|
|
||
| def start_clearml_logger( | ||
| project_name: Union[str, None] = None, |
There was a problem hiding this comment.
What is a must here? remove the None if it's must.
There was a problem hiding this comment.
Are you referring to all of the arguments? Or just project name?
There was a problem hiding this comment.
made basic args mandatory here: 31a8f07
| @@ -36,6 +36,48 @@ | |||
| from fuse.eval import MetricBase | |||
| from fuse.eval.metrics.utils import PerSampleData | |||
|
|
|||
| # for clearml | |||
| from clearml import Task | |||
There was a problem hiding this comment.
Add clearml to dependency list
There was a problem hiding this comment.
added to dependency in 31a8f07
