allow non-int sample ids in DatasetDefault #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosheraboh
requested changes
Jan 22, 2023
| @@ -187,8 +187,9 @@ def getitem( | |||
| # get sample id | |||
| if not self._explicit_sample_ids_mode: | |||
| sample_id = item | |||
| if sample_id >= self._final_sample_ids: | |||
| raise IndexError | |||
| if isinstance(sample_id, (int, np.integer)): # allow using non int sample_ids | |||
There was a problem hiding this comment.
So it means that it works?
If yes, for the official fix - I want to support it more explicitly.
In the constructor,
We will support setting sample_ids to None.
If it will set to None - it means that Dataset has no control over the used sample ids, and therefore iter() and len() will raise an error.
There was a problem hiding this comment.
yes it worked.
I made some changes, let me know if it's better
mosheraboh
previously approved these changes
Jan 22, 2023
| Optionally, you can provide an integer that describes only the size of the dataset. This is useful in massive datasets | ||
| (for example 100M samples). In such case, multiple functionalities will not be supported, mainly - | ||
| cacher, allow_uncached_sample_morphing and get_all_sample_ids | ||
| :param sample_ids: list of sample_ids included in dataset. Or: |
mosheraboh
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.