Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not strict mode in ProjectPatchesTokenizer #260

Merged
merged 8 commits into from Jan 23, 2023
Merged

not strict mode in ProjectPatchesTokenizer #260

merged 8 commits into from Jan 23, 2023

Conversation

avihu111
Copy link
Collaborator

add strict boolean argument.
when strict=False, it allows to patchify incompatible shapes.

avihu111 and others added 6 commits November 6, 2022 16:30
@avihu111
Update backbone_vit.py
b23a8b1 
add known vit architectures
@avihu111
Update backbone_vit.py
b36c57d 
add return type
@avihu111
Merge branch 'master' into add-vit-architectures
feba794
test fix
cdeed0f
Merge branch 'master' of https://github.com/BiomedSciAI/fuse-med-ml i…
40e8ee1 
…nto add-vit-architectures
add strict boolean argument.
a079521 
when strict=False, it allows to patchify incompatible shapes.
mosheraboh
mosheraboh previously approved these changes Jan 22, 2023
View reviewed changes
Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Avihu!
Approved, just one minor comment inline

fuse/dl/models/backbones/backbone_vit.py Show resolved Hide resolved
SagiPolaczek
SagiPolaczek approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@SagiPolaczek SagiPolaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
re-approved after requested changes were addressed.

@avihu111 avihu111 merged commit 165f9f6 into master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagiPolaczek SagiPolaczek SagiPolaczek approved these changes

@mosheraboh mosheraboh Awaiting requested review from mosheraboh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avihu111 @SagiPolaczek @mosheraboh