New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ndict support hydra #265

Merged

michalozeryflato merged 2 commits into master from ndict_support_hydra

Jan 26, 2023

Collaborator

michalozeryflato commented Jan 26, 2023

replace isistance(dict) with isinstance(MutableMapping) to support omegaconf.DictConfig, which is not Dict

michalozeryflato added 2 commits

January 26, 2023 10:57


          isinstance(dict) =>isinstance(MutableMapping)

e01f270


          Merge branch 'master' into ndict_support_hydra

c01dd03

mosheraboh approved these changes

View reviewed changes

Collaborator Author

michalozeryflato commented Jan 26, 2023

@mosheraboh thanks for the quick review!

michalozeryflato merged commit 40efb55 into master

michalozeryflato deleted the ndict_support_hydra branch

January 26, 2023 20:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment