Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add props to dataset and pipelines + small fix to cacher #266

Merged
merged 4 commits into from Jan 30, 2023

Conversation

michalozeryflato
Copy link
Collaborator

  1. I added these properties to allow easy access to operation objects in UKBB dataset's pipelines.
    In my case, I used it to retrieve the number of features from a "dataframe loading operation". After the dataset was created this operation stored the number of features in one of its internal field members.

  2. small fix for cacher - moved the writing of the pipeline description after the creation of the directory

Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you need the change in samples_cacher.py
But it seems ok to me in both ways,
The rest LGTM

fuse/data/datasets/caching/samples_cacher.py Show resolved Hide resolved
@michalozeryflato michalozeryflato merged commit 0e56bb9 into master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants