Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy typing fix #304

Merged
merged 14 commits into from
Apr 30, 2023
Merged

mypy typing fix #304

merged 14 commits into from
Apr 30, 2023

Conversation

SagiPolaczek
Copy link
Collaborator

@SagiPolaczek SagiPolaczek commented Apr 20, 2023 •
edited
Loading

Ready for CR 馃暫馃徏

Fixing ALL fuse's mypy errors.

Goal:

mypy . runs OK on Fuse without excluding any file.

Note that I'm doing it as a 'side task'

mosheraboh
mosheraboh approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@SagiPolaczek SagiPolaczek merged commit ad767c0 into master Apr 30, 2023
4 checks passed
@SagiPolaczek SagiPolaczek mentioned this pull request May 12, 2023
Closed
@SagiPolaczek SagiPolaczek deleted the sagi/fix_typing branch June 22, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosheraboh mosheraboh mosheraboh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SagiPolaczek @mosheraboh