New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecations #2192
Fix deprecations #2192
Conversation
This pull request fixes 12 alerts when merging fb3ce09 into 6f4d5c1 - view on LGTM.com fixed alerts:
|
This pull request fixes 12 alerts when merging fb3ce09 into 6f4d5c1 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'll see how much it prevents earlier systems from building it. Even though I don't mind dropping support for building on old systems.
This pull request fixes 12 alerts when merging a764cf9 into 6f4d5c1 - view on LGTM.com fixed alerts:
|
I've replaced most of the deprecated methods with recommended ones.
I haven't touched any QTime methods since QElapsedTimer is monotonic and doesn't allow for conversion to human readable time. I've seen at least one instance of conversion to human readable time.
I also haven't touched QJSEngine because there is no alternative for the deprecated method.
There is another deprecation warning, but it didn't make sense to me so I left it alone. It's just a
return nullptr
but the output is this:Let me know if any behavior has changed.