Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP for preprints remodel: Supplementary files #1590 take 2 #1789

Conversation

tingletech
Copy link
Contributor

@tingletech tingletech commented Aug 24, 2020

supersedes #1749

second attempt at #1590

this sort of works, but is not quite finished

I didn't commit the migration, so run python src/manage.py makemigrations

Screen Shot 2020-08-23 at 5 29 30 PM

Screen Shot 2020-08-23 at 5 29 40 PM

Screen Shot 2020-08-23 at 5 33 00 PM

Screen Shot 2020-08-23 at 5 33 12 PM

Screen Shot 2020-08-23 at 5 33 36 PM

Screen Shot 2020-08-23 at 5 33 52 PM

Screen Shot 2020-08-23 at 5 38 02 PM

@Bbkctp
Copy link
Contributor

Bbkctp commented Aug 24, 2020

Can one of the admins verify this patch?

@tingletech tingletech changed the title Supplementary files #1590 take 2 WIP for preprints remodel: Supplementary files #1590 take 2 Aug 24, 2020
@tingletech
Copy link
Contributor Author

tingletech commented Aug 24, 2020

the sequence is not hooked up right

mysql> select url, label, sequence from repository_preprintsupplementaryfile where preprint_id=1429;
+--------------------+--------+----------+
| url                | label  | sequence |
+--------------------+--------+----------+
| http://1.link.com/ | Link 1 |        1 |
| http://2.link.com/ | Link 2 |        1 |
+--------------------+--------+----------+
2 rows in set (0.00 sec)

also needs better error handling

@ajrbyers
Copy link
Member

test this please

@ajrbyers ajrbyers merged commit e173fc7 into BirkbeckCTP:preprint-remodel Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants