Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add open peer review. #141 #2602

Merged
merged 6 commits into from Sep 21, 2022
Merged

Add open peer review. #141 #2602

merged 6 commits into from Sep 21, 2022

Conversation

ajrbyers
Copy link
Member

No description provided.

@ajrbyers ajrbyers mentioned this pull request Nov 11, 2021
Closed
@ajrbyers
Copy link
Member Author

ajrbyers commented Jul 29, 2022 •
edited

  • Add Public/Open status to the new review assignment element template
  • Add front end code to the clean theme as its missing from here currently
  • Test this looks okay/works

@ajrbyers
Copy link
Member Author

Closes #141

@joemull joemull linked an issue Sep 9, 2022 that may be closed by this pull request
Peer Review: Display on Article Page #141
Closed
@joemull joemull self-requested a review September 9, 2022 12:46
@joemull joemull self-assigned this Sep 9, 2022
@ajrbyers
Copy link
Member Author

ajrbyers commented Sep 9, 2022 •
edited by joemull

  • Add document on how this should work, editors should disable file upload etc.

mauromsl
mauromsl requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor changes in line.

It would be good to also update the journal settings section of the docs with perhaps a screenshot or two

src/submission/models.py Show resolved Hide resolved
src/submission/models.py Outdated Show resolved Hide resolved
src/utils/install/journal_defaults.json Outdated Show resolved Hide resolved
@joemull joemull assigned joemull and unassigned joemull Sep 15, 2022
@joemull
Copy link
Member

joemull commented Sep 15, 2022

FYI I'm going to take this one @ajrbyers .

@joemull joemull self-requested a review September 21, 2022 13:41
joemull
joemull approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented changes requested by @mauromsl

@joemull joemull merged commit eacd5c8 into master Sep 21, 2022
@joemull joemull deleted the 141-feature-open-review-display branch September 21, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl requested changes

@joemull joemull joemull approved these changes

Assignees

@joemull joemull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Peer Review: Display on Article Page
3 participants
@ajrbyers @joemull @mauromsl