#2612 added new review setting for acceptance warning. #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mauromsl, just seeing your question now. Andy and I discussed this after he made the PR and we decided I am supposed to add something to it, but I need a function from another branch that hasn't been merged yet, #2631 . So once you or @ajrbyers review and merge that branch, I can work on this. IMHO we should move it out of 1.4.1 to avoid delays. |
|
Ah yes it can @ajrbyers. Will start working on it today |
|
Should be ready for re-review now @mauromsl |
mauromsl
requested changes
Jan 18, 2022
mauromsl
approved these changes
Jan 21, 2022
|
@mauromsl This one is ready to be merged too, I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2612