Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author display name handles empty first or last name fields #2783

Merged
merged 2 commits into from Mar 9, 2022
Merged

Author display name handles empty first or last name fields #2783

merged 2 commits into from Mar 9, 2022

Conversation

joemull
Copy link
Member

@joemull joemull commented Mar 4, 2022 •
edited

Closes #2782.

@ajrbyers
Copy link
Member

ajrbyers commented Mar 4, 2022

I think it should be fine but we will need to check if Crossref will break.

@joemull
Copy link
Member Author

joemull commented Mar 4, 2022

@ajrbyers sounds good--would you like me to check into that or make it part of review?

ajrbyers
ajrbyers approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat approach. 🎖️

@ajrbyers ajrbyers merged commit 390aa7e into master Mar 9, 2022
@ajrbyers ajrbyers deleted the 2782-full-name branch March 9, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers ajrbyers approved these changes

@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support names without first or last names
2 participants
@joemull @ajrbyers