Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2028 adds a feature flag to disable the Reviews block on the author's article page before acceptance/rejection #2945

Merged
merged 8 commits into from Sep 22, 2022
Merged

#2028 adds a feature flag to disable the Reviews block on the author's article page before acceptance/rejection #2945

merged 8 commits into from Sep 22, 2022

Conversation

ajrbyers
Copy link
Member

Closes #2028

joemull
joemull requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about the template logic and I made a suggestion for the help text.

src/templates/admin/core/article.html Outdated Show resolved Hide resolved
src/utils/install/journal_defaults.json Show resolved Hide resolved
joemull
joemull reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked a few questions about the differences between the various review visibility settings you're using and whether we could document them.

src/templates/admin/core/article.html Show resolved Hide resolved
src/templates/admin/core/article.html Outdated Show resolved Hide resolved
joemull
joemull requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to make few more changes to clean up the various settings and their documentation.

src/utils/install/journal_defaults.json Show resolved Hide resolved
docs/source/manager/review/index.rst Outdated Show resolved Hide resolved
@joemull joemull self-assigned this Sep 13, 2022
@joemull joemull marked this pull request as draft September 14, 2022 14:51
@ajrbyers
Copy link
Member Author

test this please

@joemull
Copy link
Member

joemull commented Sep 21, 2022

jenkins: test this please

@joemull joemull marked this pull request as ready for review September 21, 2022 12:21
@joemull
Copy link
Member

joemull commented Sep 21, 2022

Jenkins: test this please

@ajrbyers
Copy link
Member Author

jenkins: test this please

@ajrbyers ajrbyers merged commit 90ad1e8 into master Sep 22, 2022
@ajrbyers ajrbyers deleted the 2028-review_feature_flag branch September 22, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemull joemull joemull approved these changes

Assignees

@joemull joemull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Flag Reviews on Author Page
2 participants
@ajrbyers @joemull