Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the base structure and migrations to support en-us locale #3389

Merged
merged 2 commits into from Feb 22, 2023
Merged

Adds the base structure and migrations to support en-us locale #3389

merged 2 commits into from Feb 22, 2023

Conversation

mauromsl
Copy link
Member

@mauromsl mauromsl commented Feb 8, 2023 •
edited

  • Adds database migration for en-us support on translatable model fields
  • Adds .po files for en-us locale
  • Adds en-us to the list of supported locales

ajrbyers
ajrbyers approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ajrbyers ajrbyers left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment in line, nothing major but worth considering. If you're happy as is, merge away.

src/core/migrations/0079_auto_20230208_1233.py Outdated
name='value_en_us',
field=models.TextField(blank=True, null=True),
),
migrations.AlterField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nothing is actually being changed here, can we drop this?

@ajrbyers ajrbyers self-assigned this Feb 8, 2023
@mauromsl mauromsl merged commit ae0f311 into master Feb 22, 2023
@mauromsl mauromsl deleted the locale-en-us branch February 22, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers ajrbyers approved these changes

Assignees

@ajrbyers ajrbyers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mauromsl @ajrbyers