Add `DfTx` for Create & Resign MasterNode #283

ivan-zynesis · 2021-05-24T11:13:57Z

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

for explorer to decode
to create/resign masternode in future

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

codeclimate · 2021-05-24T11:14:17Z

Code Climate has analyzed commit 627104f and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

github-actions · 2021-05-24T11:17:47Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/jellyfish/dist/jellyfish.umd.js	19.16 KB (0%)	384 ms (0%)	166 ms (-2.04% 🔽)	549 ms

codecov · 2021-05-24T11:33:24Z

Codecov Report

Merging #283 (627104f) into main (9c238a0) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   96.49%   96.89%   +0.39%     
==========================================
  Files          85       89       +4     
  Lines        2228     2380     +152     
  Branches      287      304      +17     
==========================================
+ Hits         2150     2306     +156     
+ Misses         78       74       -4

Impacted Files	Coverage Δ
...ellyfish-transaction/src/buffer/buffer_composer.ts	`99.46% <100.00%> (+0.08%)`	⬆️
...ages/jellyfish-transaction/src/script/defi/dftx.ts	`97.01% <100.00%> (+0.93%)`	⬆️
...ish-transaction/src/script/defi/dftx_masternode.ts	`100.00% <100.00%> (ø)`
...ckages/jellyfish-transaction/src/script/mapping.ts	`96.20% <100.00%> (+0.96%)`	⬆️
packages/jellyfish-api-core/src/category/wallet.ts	`100.00% <0.00%> (ø)`
...ages/jellyfish-api-core/src/category/blockchain.ts	`100.00% <0.00%> (ø)`
...ellyfish-transaction/src/script/defi/dftx_token.ts	`100.00% <0.00%> (ø)`
...tcontainers/src/chains/reg_test_container/index.ts	`100.00% <0.00%> (ø)`
...lyfish-transaction/src/script/defi/dftx_oracles.ts	`100.00% <0.00%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c238a0...627104f. Read the comment docs.

packages/jellyfish-transaction/src/script/defi/dftx_masternode.ts

Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>

packages/jellyfish-transaction/src/script/defi/dftx_masternode.ts

netlify · 2021-05-25T03:11:47Z

Deploy Preview for jellyfish-defi ready!

Built with commit d08aeef

https://deploy-preview-283--jellyfish-defi.netlify.app

fuxingloh

1 minor change in BufferComposer

packages/jellyfish-transaction/src/buffer/buffer_composer.ts

fuxingloh · 2021-05-25T10:03:50Z

Failing test, wrong error message

* added dftx.indexer scaffolding * rewrote oracle into forward aggregation * added controller * added client oracles.ts * fix aggregated derivation * separated price client * refactor index * added price ticker * fixed dftx indexer issues * completed prices tests * fixed existing test failures * completed oracle invalidate test * fixed update.oracle.ts uncertainty test * Added interval indexers * Fixed tests * Modified interval to use time * Aggregate if no previous entries * Invalidate changes * Median time is in seconds * Added passing tests for interval indexer * Get rid of old controller names * Added controller functionality * Added controller functionality * Added whale api and tests * Fix code smell * Improve test coverage * Add greater than for prices * Sum up previous prices * Better aggregation * Fixed tests * Update packages/whale-api-client/src/api/prices.ts Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com> * Change url * Update packages/whale-api-client/src/api/oracles.ts Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com> * Increase limit * Fix test * Fix tests * Fix test url * Update src/module.indexer/model/dftx/set.oracle.data.ts Co-authored-by: Ivan Lee <44192990+ivan-zynesis@users.noreply.github.com> * Convert to key * Averaged * Fix client tests * Implement forward aggregation * Comments * Add parse int pipe * Fix typo in tests * Reduce indentation depth and remove spread operator * Added invalidation * Revised algorithm * Split out into another indexer * Update src/module.indexer/model/dftx/set.oracle.data.interval.ts Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com> * Update src/module.indexer/model/dftx/set.oracle.data.interval.ts Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com> * PR Feedback * Fix tests Co-authored-by: Fuxing Loh <git@fuxing.dev> Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com> Co-authored-by: Ivan Lee <44192990+ivan-zynesis@users.noreply.github.com>

ivan-zynesis added 2 commits May 24, 2021 17:41

quick save

a11cb28

add resign-master-node dftx

5ce5d42

ivan-zynesis requested review from canonbrother, fuxingloh and jingyi2811 as code owners May 24, 2021 11:13

ivan-zynesis marked this pull request as draft May 24, 2021 11:14

defichain-bot added kind/feature New feature request area/jellyfish-transaction labels May 24, 2021

defichain-bot assigned ivan-zynesis May 24, 2021

ivan-zynesis mentioned this pull request May 24, 2021

DeFi CustomTx scripting #108

Closed

17 tasks

fix field description, nodeId length

205f694

ivan-zynesis marked this pull request as ready for review May 24, 2021 11:31

fuxingloh changed the title ~~Feature/dftx scripting/create remove mn~~ Add DfTx for Create & Resign MasterNode May 24, 2021

fuxingloh requested changes May 24, 2021

View reviewed changes

packages/jellyfish-transaction/src/script/defi/dftx_masternode.ts Show resolved Hide resolved

fuxingloh marked this pull request as draft May 24, 2021 16:00

fuxingloh reviewed May 24, 2021

View reviewed changes

packages/jellyfish-transaction/src/script/defi/dftx_masternode.ts Outdated Show resolved Hide resolved

ivan-zynesis and others added 3 commits May 25, 2021 09:04

Update packages/jellyfish-transaction/src/script/defi/dftx_masternode.ts

02f4018

Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>

fix test, nodeId should be reversed before buffer (when read by eye)

608ad26

add (optional) operatorPubKeyHash to CreateMasterNode

d08aeef

codeclimate bot reviewed May 25, 2021

View reviewed changes

packages/jellyfish-transaction/src/script/defi/dftx_masternode.ts Show resolved Hide resolved

refactor buffer composer of optionalHex

2cf194c

ivan-zynesis marked this pull request as ready for review May 25, 2021 06:45

fuxingloh requested changes May 25, 2021

View reviewed changes

packages/jellyfish-transaction/src/buffer/buffer_composer.ts Outdated Show resolved Hide resolved

packages/jellyfish-transaction/src/buffer/buffer_composer.ts Outdated Show resolved Hide resolved

fuxingloh marked this pull request as draft May 25, 2021 08:25

address change requested

9c2323f

codeclimate bot reviewed May 25, 2021

View reviewed changes

packages/jellyfish-transaction/src/buffer/buffer_composer.ts Show resolved Hide resolved

ivan-zynesis marked this pull request as ready for review May 25, 2021 09:34

ivan-zynesis requested a review from fuxingloh May 25, 2021 09:34

fuxingloh marked this pull request as draft May 25, 2021 12:20

fuxingloh added 2 commits May 26, 2021 19:26

Update buffer_composer.test.ts

3aabddc

Update CreateMasterNode.test.ts

627104f

fuxingloh marked this pull request as ready for review May 26, 2021 11:48

fuxingloh approved these changes May 26, 2021

View reviewed changes

fuxingloh enabled auto-merge (squash) May 26, 2021 11:48

canonbrother approved these changes May 27, 2021

View reviewed changes

fuxingloh merged commit 2713333 into main May 27, 2021

fuxingloh deleted the feature/dftx-scripting/create-remove-mn branch May 27, 2021 02:05

fuxingloh mentioned this pull request May 27, 2021

Add DfTx TokenUpdate, TokenUpdateAny #300

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `DfTx` for Create & Resign MasterNode #283

Add `DfTx` for Create & Resign MasterNode #283

ivan-zynesis commented May 24, 2021

codeclimate bot commented May 24, 2021 •

edited

Loading

github-actions bot commented May 24, 2021 •

edited

Loading

codecov bot commented May 24, 2021 •

edited

Loading

netlify bot commented May 25, 2021

fuxingloh left a comment

fuxingloh commented May 25, 2021

Add DfTx for Create & Resign MasterNode #283

Add DfTx for Create & Resign MasterNode #283

Conversation

ivan-zynesis commented May 24, 2021

What kind of PR is this?:

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Additional comments?:

codeclimate bot commented May 24, 2021 • edited Loading

github-actions bot commented May 24, 2021 • edited Loading

size-limit report 📦

codecov bot commented May 24, 2021 • edited Loading

Codecov Report

netlify bot commented May 25, 2021

fuxingloh left a comment

Choose a reason for hiding this comment

fuxingloh commented May 25, 2021

Add `DfTx` for Create & Resign MasterNode #283

Add `DfTx` for Create & Resign MasterNode #283

codeclimate bot commented May 24, 2021 •

edited

Loading

github-actions bot commented May 24, 2021 •

edited

Loading

codecov bot commented May 24, 2021 •

edited

Loading