Fix the bug of the corresponding relationship between dwLogonType and dwLogonProvider in MakeToken #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkervella
previously approved these changes
Dec 21, 2022
|
@s3cst4rs please resubmit with a signed commit. We won't be able to merge otherwise. |
… dwLogonProvider in MakeToken
du0L
approved these changes
Dec 29, 2022
|
@rkervella when can merge? |
rkervella
approved these changes
Dec 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card
Details
Using LOGON32_LOGON_NEW_CREDENTIALS for Token verification is a very good solution, but according to the description of MSDN, there is a problem with the function call here.
When dwLogonType uses LOGON32_LOGON_NEW_CREDENTIALS, This logon type is supported only by the LOGON32_PROVIDER_WINNT50 logon provider.
https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-logonusera