Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix implant configuration for external builders #1180

Merged
merged 2 commits into from Apr 5, 2023

Conversation

MrAle98
Copy link
Contributor

@MrAle98 MrAle98 commented Apr 4, 2023

Card

PR for addressing issue #1105

Details

Added just ECCPrivateKey ECCPublicKey and ECCServerPublicKey to external implant building.
.proto files were modified in order to add the information.
ImplantConfig.ToProtobuf() and ImplantConfigFromProtobuf() were modified in order to add ECCPrivateKey ECCPublicKey and ECCServerPublicKey to the configuration of the external builder and compile a runnable implant.

@MrAle98 MrAle98 requested a review from a team as a code owner April 4, 2023 14:34
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-scanning.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Copy link
Member

@rkervella rkervella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing, otherwise looks good to me.

server/db/models/implant.go Outdated Show resolved Hide resolved
@moloch-- moloch-- merged commit ec7e76f into BishopFox:master Apr 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants