Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few bugs #990

Merged
merged 5 commits into from
Nov 5, 2022
Merged

Fix a few bugs #990

merged 5 commits into from
Nov 5, 2022

Conversation

rkervella
Copy link
Member

@rkervella rkervella commented Nov 5, 2022 •
edited

  • Allow terminate to be used with beacons.
  • Fix a few issues in netstat
  • Add a debug target to the makefile to compile the client and server with debug symbols

@rkervella rkervella requested a review from a team as a code owner November 5, 2022 00:25
@moloch--
Copy link
Member

moloch-- commented Nov 5, 2022

@DominicBreuker to answer your question about why terminate wasn't supported in beacon mode, the answer is: we forgot to port it :)

@moloch-- moloch-- merged commit 1be1904 into master Nov 5, 2022
@DominicBreuker
Copy link
Contributor

Oh, very nice and thx :)
I'll update when v1.5.32 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moloch-- moloch-- moloch-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rkervella @moloch-- @DominicBreuker