Skip to content

Commit

Permalink
apacheGH-35118: [FlightSQL] Use int32 to refer to 32-bit integers r…
Browse files Browse the repository at this point in the history
…ather than `int` (apache#35120)

### Rationale for this change

The spec is inconsistent -- see details on apache#35118 

### What changes are included in this PR?

Use `int32` to refer to 32-bit integers rather than `int`

### Are these changes tested?

No, only comments are changed

### Are there any user-facing changes?

This clarifies a small corner case in the document

* Closes: apache#35118
* Closes: apache#35118

Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
  • Loading branch information
appletreeisyellow authored and ArgusLi committed May 15, 2023
1 parent a6c9674 commit 682a741
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions format/FlightSql.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ message CommandGetTableTypes {
* table_name: utf8 not null,
* column_name: utf8 not null,
* key_name: utf8,
* key_sequence: int not null
* key_sequence: int32 not null
* >
* The returned data should be ordered by catalog_name, db_schema_name, table_name, key_name, then key_sequence.
*/
Expand Down Expand Up @@ -1321,7 +1321,7 @@ enum UpdateDeleteRules {
* fk_db_schema_name: utf8,
* fk_table_name: utf8 not null,
* fk_column_name: utf8 not null,
* key_sequence: int not null,
* key_sequence: int32 not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint8 not null,
Expand Down Expand Up @@ -1367,7 +1367,7 @@ message CommandGetExportedKeys {
* fk_db_schema_name: utf8,
* fk_table_name: utf8 not null,
* fk_column_name: utf8 not null,
* key_sequence: int not null,
* key_sequence: int32 not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint8 not null,
Expand Down Expand Up @@ -1420,7 +1420,7 @@ message CommandGetImportedKeys {
* fk_db_schema_name: utf8,
* fk_table_name: utf8 not null,
* fk_column_name: utf8 not null,
* key_sequence: int not null,
* key_sequence: int32 not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint8 not null,
Expand Down

0 comments on commit 682a741

Please sign in to comment.