GH-35118: [FlightSQL] Use int32 to refer to 32-bit integers rather than int
#35120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than `int`
|
|
alamb
approved these changes
Apr 13, 2023
github-actions
bot
added
awaiting merge
|
Related PR: #35108 |
|
Thanks again @appletreeisyellow |
|
Benchmark runs are scheduled for baseline = 4328eba and contender = 3ff3cc8. 3ff3cc8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
kou
pushed a commit
that referenced
this pull request
Apr 18, 2023
…egers rather than `int` (#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue #35118. #35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: #35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…ather than `int` (apache#35120) ### Rationale for this change The spec is inconsistent -- see details on apache#35118 ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…it integers rather than `int` (apache#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…ather than `int` (apache#35120) ### Rationale for this change The spec is inconsistent -- see details on apache#35118 ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…it integers rather than `int` (apache#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…ather than `int` (apache#35120) ### Rationale for this change The spec is inconsistent -- see details on apache#35118 ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…it integers rather than `int` (apache#35213) ### Rationale for this change There are more inconsistency of the spec format found -- see details on the original issue apache#35118. apache#35120 is the first PR with the same fix. ### What changes are included in this PR? Use `int32` to refer to 32-bit integers rather than `int` ### Are these changes tested? No, only comments are changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35118 Authored-by: Chunchun <14298407+appletreeisyellow@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The spec is inconsistent -- see details on #35118
What changes are included in this PR?
Use
int32to refer to 32-bit integers rather thanintAre these changes tested?
No, only comments are changed
Are there any user-facing changes?
This clarifies a small corner case in the document