Add results as comments to TransactionTestUtilities.java #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
| Map.of("timeout", "1000"), | ||
| OK | ||
| OK, // set(key1, value1) | ||
| value1, // get(key1) |
There was a problem hiding this comment.
why not just add the command name like // set feels a bit too much to add the whole command.
There was a problem hiding this comment.
I can change it if you feel strongly. This is a little easier to maintain/follow because it's more unique.
There was a problem hiding this comment.
It's not that I feel strongly about it this is was how Yurry was also doing it and my PRs are following that. Your call.
|
Can you apply your change on my branch in #160? |
Yury-Fridlyand
added a commit
that referenced
this pull request
Mar 27, 2024
|
closing this in favour of https://github.com/Bit-Quill/glide-for-redis/pull/160/files |
Yury-Fridlyand
added a commit
that referenced
this pull request
Apr 12, 2024
Yury-Fridlyand
added a commit
that referenced
this pull request
Apr 15, 2024
* Ease transaction IT updating and fixing. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix test and command manager. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * SPOTLESS I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Copy from #165. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Revert some refactoring. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Revert timeout change. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * SPOTLESS I HATE YOU Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Group commands in transaction IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Refresh Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Test fixes. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix for redis 6. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.