Update transaction handling and IT #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
alex-arzola-imp,
acarbonetto and
SanHalacogluImproving
SanHalacogluImproving
approved these changes
Mar 25, 2024
acarbonetto
reviewed
Mar 27, 2024
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
changed the title
acarbonetto
reviewed
Mar 27, 2024
acarbonetto
reviewed
Mar 27, 2024
| private static final String field1 = UUID.randomUUID().toString(); | ||
| private static final String field2 = UUID.randomUUID().toString(); | ||
| private static final String field3 = UUID.randomUUID().toString(); | ||
| private static final String stringKey1 = "{test}:stringKey1-" + UUID.randomUUID(); |
There was a problem hiding this comment.
I suggest only renaming the variable. I don't see the benefit of renaming the key.
There was a problem hiding this comment.
It helped for post-mortem debugging the test - I kept the cluster running for querying them.
java/integTest/src/test/java/glide/cluster/ClusterTransactionTests.java
Outdated
Show resolved
Hide resolved
|
Round |
jonathanl-bq
approved these changes
Mar 29, 2024
acarbonetto
approved these changes
Apr 1, 2024
Merged
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
force-pushed
the
java/dev_yuryf_transaction_IT
branch
from
442ab1f
to
2b40d08
Compare
Yury-Fridlyand
requested review from
jonathanl-bq,
SanHalacogluImproving and
acarbonetto
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
jonathanl-bq
approved these changes
Apr 12, 2024
Yury-Fridlyand
merged commit 77c32e1
into
java/integ_yuryf_transaction_IT
11 checks passed
Yury-Fridlyand
added a commit
that referenced
this pull request
May 10, 2024
* Update transaction handling and IT (#160) * Ease transaction IT updating and fixing. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Update transaction handling and IT (#160) * Ease transaction IT updating and fixing. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandManagertransaction related methods.