Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WYSIWYG plugin for HTML type #120

Closed
gabiudrescu opened this issue Feb 16, 2018 · 6 comments
Closed

Add WYSIWYG plugin for HTML type #120

gabiudrescu opened this issue Feb 16, 2018 · 6 comments

Comments

@gabiudrescu
Copy link
Contributor

While watching the webinar from last week, I just realized that the HTML content block is missing a WYSIWYG form in admin to be more user friendly.

And from the implementation point of view, I guess this means:

  • add WYSIWYG bundle as a dependency to this plugin
  • change HtmlBlockTranslationType from TextareaType::class to CKEditorType::class

wdyt?

@bitbager
Copy link
Member

We have inclued a customozation guide for it. We will probably add it to the core with a nice toggle switch for the WYSIWYG editor. Leaving it as opened, thanks!

@bitbager
Copy link
Member

It's coming with the v2.0.0! 🎉

@gabiudrescu
Copy link
Contributor Author

Maybe you can implement this WYSIWYG editor: https://github.com/yakovlevga/brickyeditor

I think it will be better, from user point of view, to be able to edit static blocks on the website like that.

Or, if you plan to use CKEditor, maybe that one can also have the WYSIWYG feature enabled: https://sdk.ckeditor.com/samples/inline.html

@bitbager
Copy link
Member

Hi @gabiudrescu. How does the editor differ from CKEditor? Actually, we already integrated CKEditor with the plugin due to easy to install FOSCKEditorBundle 🙁

@gabiudrescu
Copy link
Contributor Author

brickyeditor is more friendly to inline editing right on the front end of the website.

you can pull the same with CKEditor though... but from what I learned, brickyeditor is better for such things. give it a try :)

@bitbager
Copy link
Member

At this moment, we decided to use CKEditor. We will see how it goes in the future 🙂

bitbager pushed a commit that referenced this issue Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants