Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page in admin has no title #40

Closed
bitbager opened this issue Oct 18, 2017 · 4 comments
Closed

Page in admin has no title #40

bitbager opened this issue Oct 18, 2017 · 4 comments
Labels

Comments

@bitbager
Copy link
Member

In the admin panel, when we go to the pages page, which btw sounds so weird, we don't have the nice "Pages" title 🙁

@kochen
Copy link
Contributor

kochen commented Oct 31, 2017

@bitbager are you reffering to this?
image

@bitbager
Copy link
Member Author

No, the page title is | Pages instead of Sylius | Pages. Actually is already fixed on dev branch. We can close it.

@kochen
Copy link
Contributor

kochen commented Oct 31, 2017

@bitbager not sure why you closed this, but the title should actually be:

{% block title %}{{ header|trans }}{{ parent() }}{% endblock %}

instead of:

{% block title %}{{ parent() }} {{ header|trans }}{% endblock %}

Shall I create a PR?

@bitbager
Copy link
Member Author

bitbager pushed a commit to bitbager/SyliusCmsPlugin that referenced this issue Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants