Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix page sections layout #100

Merged
merged 2 commits into from
Nov 23, 2017
Merged

fix page sections layout #100

merged 2 commits into from
Nov 23, 2017

Conversation

victordit
Copy link

No description provided.

<div class="bitbag-page-sections">
{% include '@BitBagCmsPlugin/Shop/Page/Show/_sections.html.twig' %}
</div>
</div>
{% if null != page.products %}
{% if (page.products|length) > 0 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the bracket?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but why ? fix CS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of our coding standard, we don't use brackets if not necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done! :)

@bitbager
Copy link
Member

Thanks!

@bitbager bitbager merged commit 8c3bdde into BitBagCommerce:master Nov 23, 2017
bitbager pushed a commit that referenced this pull request Jul 16, 2018
Bring 1.1/master fixes to 1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants