Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAQ] Adding, grid #57

Merged
merged 31 commits into from
Nov 2, 2017
Merged

[FAQ] Adding, grid #57

merged 31 commits into from
Nov 2, 2017

Conversation

shinoks
Copy link
Contributor

@shinoks shinoks commented Nov 1, 2017

Adding - works but need to check code field (null/not null default value)

shinoks and others added 30 commits September 13, 2017 07:28
Update Sylius to 1.0.0 and PHP to 7.1+
[Page] Check if products exist
Need more fixes with translated names
[Block][Page] Fix grid sorting
Works,
Last test fail
But need to check code null/not null
last test fail
@@ -8,6 +8,9 @@ BitBag\CmsPlugin\Entity\FrequentlyAskedQuestion:
generator:
strategy: AUTO
fields:
code:
type: string
nullable: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code can not be null :)

@bitbager bitbager merged commit 071ab8d into BitBagCommerce:dev Nov 2, 2017
bitbager pushed a commit to bitbager/SyliusCmsPlugin that referenced this pull request Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants