Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.11 #37

Merged
merged 10 commits into from
Apr 14, 2022
Merged

Update to 1.11 #37

merged 10 commits into from
Apr 14, 2022

Conversation

kuba-end
Copy link
Contributor

No description provided.

Copy link

@jakubtobiasz jakubtobiasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall feedback is good, just replace every occurrence of event name with const. I've just commented this once but apply in all cases :P.

tests/Behat/Service/ElasticsearchCommands.php Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@PiotrSzymanski2000 PiotrSzymanski2000 merged commit 093b430 into master Apr 14, 2022
senghe added a commit that referenced this pull request Apr 28, 2022
@senghe senghe mentioned this pull request Apr 28, 2022
liszkapawel pushed a commit that referenced this pull request May 9, 2022
* Update to 1.11

* fix github actions

* fix github actions

* fix github actions

* fix github actions

* fix behat tests

* refactor after cr

* fix workflow

* fix workflow

* refactor ElasticsearchCommands

Co-authored-by: piotr <piotr.szymanski@bitbag.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants