You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code was originally written for an old version of VC++ which had a lot more quirks than 2015. Some of the warning removal pragmas can probably be removed, and many of the ones that can't be removed should probably have better documentation.
It shouldn't be that hard to write a script that removes the pragmas one-by-one to see which ones are no longer necessary.
Also, in some cases, we might be able to just change the code to work cross-platform without some kind of platform-specific #ifdef'd pragma.
The text was updated successfully, but these errors were encountered:
I was thinking about doing this but we have 7 outstanding PRs for code review and it's basically guaranteed that this will conflict with at least one of those when we try to merge.
This code was originally written for an old version of VC++ which had a lot more quirks than 2015. Some of the warning removal pragmas can probably be removed, and many of the ones that can't be removed should probably have better documentation.
It shouldn't be that hard to write a script that removes the pragmas one-by-one to see which ones are no longer necessary.
Also, in some cases, we might be able to just change the code to work cross-platform without some kind of platform-specific #ifdef'd pragma.
The text was updated successfully, but these errors were encountered: