Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine which VC++ warning removal pragmas we don't need #15

Closed
danluu opened this issue Apr 19, 2016 · 2 comments
Closed

Determine which VC++ warning removal pragmas we don't need #15

danluu opened this issue Apr 19, 2016 · 2 comments

Comments

@danluu
Copy link
Contributor

danluu commented Apr 19, 2016

This code was originally written for an old version of VC++ which had a lot more quirks than 2015. Some of the warning removal pragmas can probably be removed, and many of the ones that can't be removed should probably have better documentation.

It shouldn't be that hard to write a script that removes the pragmas one-by-one to see which ones are no longer necessary.

Also, in some cases, we might be able to just change the code to work cross-platform without some kind of platform-specific #ifdef'd pragma.

@danluu
Copy link
Contributor Author

danluu commented Jun 8, 2016

I was thinking about doing this but we have 7 outstanding PRs for code review and it's basically guaranteed that this will conflict with at least one of those when we try to merge.

@danluu
Copy link
Contributor Author

danluu commented Jun 29, 2016

I send out a codeflow for review for this the other day. It's pretty trivial and I'll merge it one it passes code review.

danluu added a commit to danluu/NativeJIT that referenced this issue Jul 1, 2016
@danluu danluu closed this as completed in e79d250 Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant