fix text color in amount edit widget for dark style #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second call to `ColorScheme.update_from_widget` did not take the user setting (`force_dark`) into consideration, so it overwrote the ColorScheme setting. This is strange because I would expect the first call to change the stylesheet, and so make the second call autodetect that the dark theme is in use via `ColorScheme.has_dark_background`, but it somehow does not work. Maybe Qt change something in the way the stylesheet is applied, and it is not taken into account by the time the second call occurs. This changes the behavior to the one used by electrum. Hopefully there aren't too many Electrum ABC plugins messing with the color theme.
cculianu
pushed a commit
to cculianu/Electron-Cash
that referenced
this pull request
May 27, 2022
It turns out it was broken all this time. This is a partial backport of: Bitcoin-ABC#210
PiRK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second call to
ColorScheme.update_from_widgetdid not take the user setting (force_dark) into consideration, and was not able to detect that the first call set the dark theme, so it overwrote theColorSchemesetting used by the amount edit widget to determine the text color.This is strange because I would expect the first call to change the stylesheet, and so make the second call autodetect that the dark theme is in use via
ColorScheme.has_dark_background, but it somehow does not work. Maybe Qt does not apply the stylesheet before reaching the event loop, so the autodetection of the theme base on theQWidgetbackground color does not work at this point in the initialization of the application.Before:
After: