Warn if a legacy addres is used #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both include good bug fixes. One user hit the issue where `libusb_get_device_list` returned `LIBUSB_ERROR_OTHER` which is fixed by this commit included in libusb 1.0.23: libusb/libusb@fd95d44 closes Electron-Cash#2132 Backport note: - python libusb1 was already updated for ElectrumABC
Seed generation: use BIP39 by default for better compatibility: * Most (all?) hardware wallets use BIP39 seeds in combination with BIP43-style derivation paths (like m / purpose' / coin_type' / account' / change / address_index) * Electrum uses BIP43 derivation paths for all hardware wallets, AND for BIP39 seeds imported in software wallets * Electrum seeds (not BIP39) use seed versioning instead of purpose derivation path. * Software wallets with Electrum seeds use "m / change / address_index" derivation paths User interface improvements: * 2FA config is removed from initial setup as it confuses some users * Instead, 2FA can be activated from the option menu (clicking on the Satochip logo on the lower right corner Other minor corrections: * PIN can have a maximum length of 16, not 64 Backport notes: - some minor changes were necessery to account for ElectrumABC PR Electron-Cash#57 - untested because I do not own a satochip card
During wallet creation, the following error sometimes pops to the user: "Failed to create a client for this device. Make sure it is in a correct state". This error does not always show, and even when it does, it does not stop the wallet creation. This issue is generated in the method 'has_usable_connection_with_device()'. The reason is that sometimes the card is not ready when the wizard tries to connect to it. Retrying after a short delay is enough to solve the issue.
Legacy addresses are the source of confusion for many BCHA users. See: https://blog.cex.io/news/why-you-should-never-send-bch-to-btc-address-21346 This changeset creates a popup warning window when the user tries to send BCHA to a legacy address. The window has a "Never show this again" checkbox.
|
Thanks. For some reason I did not get a notification and just saw your PR right now. Will review soon. |
Merged
|
Closed in favor of #89 I cherry-picked your commit and added a few minor changes, to avoid hardcoding the project name "Electrum ABC" or the currency unit name. I want to be able to change these in a single place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy addresses are the source of confusion for many BCHA users.
See:
https://blog.cex.io/news/why-you-should-never-send-bch-to-btc-address-21346
This changeset creates a popup warning window when the user tries to
send BCHA to a legacy address. The window has a "Never show this again"
checkbox.
This is a backport of Electron-Cash#2129.
This change is