-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if a legacy addres is used #2129
Conversation
Legacy addresses are the source of confusion for many BCH users. See: https://blog.cex.io/news/why-you-should-never-send-bch-to-btc-address-21346 This changeset creates a popup warning window when the user tries to send BCH to a legacy address. The window has a "Never show this again" checkbox.
This commit is a great idea. Thanks for the contribution. Will review... |
I also wanted to point out that since Electron Cash and Electrum are very similar applications in look and feel, a user might have both Electron Cash and Electrum open at the same time, and copypaste a legacy address on Electron Cash when meaning to do it on Electrum. This changeset will mitigate those human errors. |
Hmm. Yeah I never thought about that. |
Ping @gasull |
Sorry, I was unable to work on this lately. Getting back to it now. |
@cculianu , this is ready to be code-reviewed again. |
Looks great. I like it. I reviewed. Merging. Note I want to modify the test a bit -- but I can do that myself. Just a word or two. Great work. I like how you added a "Show details.." text.. and the text makes sense. |
Also modified the formattng a little bit.
Also modified the formattng a little bit.
Also modified the formattng a little bit.
Also modified the formattng a little bit.
Legacy addresses are the source of confusion for many BCH users.
See Why you should never send your BCH to BTC address.
This changeset creates a popup warning window when the user tries to
send BCH to a legacy address. The window has a "Never show this again"
checkbox.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)