error annotation leads to puzzle #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 13, 2021
Summary --- This MR is part of on-going work to optimize `CTxMemPool::removeForBlock`, as discussed in issue Bitcoin-ABC#161. As such, it adds a benchmark for this function versus a full mempool of ~450k unchained txns. The bench calls removeForBlock repeatedly with block txns from a ~32MB block versus a very full mempool. Also an 8MB block version is provided as well. Test Plan --- - `ninja all check bench_bitcoin` - `src/bench/bench_bitcoin -filter='RemoveForBlock.*'`
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 13, 2021
Summary --- As discussed in issue Bitcoin-ABC#161, the performance of `removeForBlock` in particular is a critical path that deserves optimization. This MR significantly improves the performance of `removeForBlock` from 0% to as much as 100% or more, depending on the exact mempool layout in question. The changes introduced also happen to improve the general performance of the mempool as well. Minor RPC Change --- - As a result of these optimizations, the mempool-related RPC calls that describe a mempool entry's `spentby` (list of mempool txs that spend a particular mempool tx) have a different sort order now. Previously, this list would be sorted by txid. Now, it is sorted topologically. - `getmempooldescendants` and `getmempoolancestors` now also no longer returns a list that is sorted by `TxId` but is rather topologically sorted (by `entryId`). Test Plan --- - `ninja all check-all` Run these benches on master versus this MR commit: - `ninja bench_bitcoin && src/bench/bench_bitcoin -filter='(RemoveForBlock.*)|(MempoolAcc.*)|(Reorg.*)|(Generat.*)|(Evict.*)'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InsecureRandRange(10) will generate a random number in [0, 10], that is ten every eleven iterations...