Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Add method http_get #1629

Merged
merged 1 commit into from Apr 1, 2019
Merged

Conversation

dagurval
Copy link
Collaborator

No description provided.

@dagurval
Copy link
Collaborator Author

I need this for fetching runtime statistics from electrum server. Pushing as a separate pull request to check if all the new boost stuff works on travis.

@sickpig
Copy link
Collaborator

sickpig commented Mar 26, 2019

@dagurval

../../src/utilhttp.cpp:4:10: fatal error: 'boost/beast/core.hpp' file not found
#include <boost/beast/core.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~

@dagurval
Copy link
Collaborator Author

dagurval commented Mar 26, 2019

Looks like this requires boost 1.651.66, while BU is on boost 1.64. Can we upgrade? :-)

@sickpig
Copy link
Collaborator

sickpig commented Mar 26, 2019

@dagurval

we could upgrade the dependencies to use boost 1.65 rather than 1.64.

Even bionic come with 1.65. If we decide to upgrade and ask boost >= 1.65 as requirement we should provide some guidance to the people who are using older but still supported distro and are not using gitian binaries or ubuntu ppa repo.

What other people think?

@dagurval dagurval force-pushed the http-get branch 3 times, most recently from 8dff940 to 6dc296f Compare March 27, 2019 14:42
@dagurval
Copy link
Collaborator Author

Re-written to use libevent instead of boost. This is worse, but it doesn't require newer boost functionality.

@sickpig sickpig added the RPC label Mar 27, 2019
@sickpig
Copy link
Collaborator

sickpig commented Mar 27, 2019

@dagurval thanks for doing it!

I wonder if we could move all out util*.{cpp,h} in separate dir, maybe src/util?

This something for another PR thou.

src/utilhttp.cpp Outdated Show resolved Hide resolved
@gandrewstone
Copy link
Collaborator

    DbgAssert(static_cast<size_t>(s) <= sizeof buffer, {return });

has an error. just use:

    DbgAssert(static_cast<size_t>(s) <= sizeof buffer, return);

@dagurval dagurval force-pushed the http-get branch 3 times, most recently from 05497f2 to ccc6a37 Compare March 31, 2019 22:42
@gandrewstone gandrewstone merged commit 04f9002 into BitcoinUnlimited:dev Apr 1, 2019
@dagurval dagurval deleted the http-get branch April 1, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants