New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic integration with the electrum server electrs #1633
Conversation
A way to test this with Electron Cash is by running
and creating a wallet with the tpub key Electron Cash also has added a nice feature to rebuild the wallet history Beware of this bug in electron cash Electron-Cash/Electron-Cash#1222 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding some words about what elecrtrs is?
I did an out-of-source-tree build but the electrs binary still goes to src/electrs. To replicate this, from your base git checkout dir: |
src/electrum/electrumserver.cpp
Outdated
ss << path; | ||
for (auto &a : args) | ||
{ | ||
ss << a << " "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ss << " " << a;
Or you get an executable named "electrs-vvvv", and an extra space at the end I presume, (in the log only).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
I get:
BUT when I run the spawn line directly on the command line I get:
so it looks like its working from the command line. |
Weird. Not sure how to reproduce that. Does the qa test run? |
12c9b71
to
efb3e80
Compare
Makefile.am
Outdated
@@ -218,6 +218,9 @@ endif | |||
check-formatting: | |||
$(MAKE) -C src $@ | |||
|
|||
electrs: ${PWD}/src/electrs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PWD is not necessarily the out-of-source dir, use top_builddir. And if ${PWD}/src/electrs does not exist, there's no rule to make it. Instead use a phony target that points to the real target like this:
.PHONY: electrs
electrs: $(top_builddir)/src/electrs
$(top_builddir)/src/electrs:
$(top_srcdir)/contrib/electrs/build_electrs.py --dst=$(top_builddir)/src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8100042
Rebased again on top of #1645 and added gitian build support on Linux |
Includes new make target 'electrs'
This integrates the electrum server electrs. This server can be spawned by Bitcoin Unlimited by adding the configurmation parameter electrum=1
This is a MVP for integrating electrum server with Bitcoin Unlimited.
To enable the server, you need to run
make electrs
and addelectrum=1
tobitcoin.conf
. Addingdebug=electrum
will enable more useful logging.