Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up devcontainer build #144

Closed
kjaymiller opened this issue Nov 13, 2023 · 9 comments · Fixed by #153 or #158
Closed

Speed up devcontainer build #144

kjaymiller opened this issue Nov 13, 2023 · 9 comments · Fixed by #153 or #158
Assignees
Labels
devcontainer enhancement New feature or request

Comments

@kjaymiller
Copy link
Contributor

Not sure why but my devcontainer/codespace for the website takes incredibly long to build.

Perhaps we can investigate and make sure that we're not over-installing dependencies.

@oleksis
Copy link
Contributor

oleksis commented Nov 13, 2023

I will push the image to GitHub Container registry

@jefftriplett
Copy link

From other Jekyll + GitHub Pages + Docker setups I have used, we have struggled to get Ruby to keep a cache of everything it needs to run. It's been a year(ish) since I looked, but it used to do a fresh gem install when the container started.

If @oleksis's container is doing that then using the image should help skip a bunch of slow steps.

@oleksis
Copy link
Contributor

oleksis commented Nov 14, 2023

Thanks for the advice @jefftriplett

@oleksis oleksis added enhancement New feature or request devcontainer labels Nov 15, 2023
@oleksis
Copy link
Contributor

oleksis commented Nov 16, 2023

oleksis added a commit to oleksis/blackpythondevs.com that referenced this issue Nov 17, 2023
oleksis added a commit that referenced this issue Nov 17, 2023
@kjaymiller kjaymiller linked a pull request Nov 17, 2023 that will close this issue
@oleksis
Copy link
Contributor

oleksis commented Nov 17, 2023

@kjaymiller
Copy link
Contributor Author

Great work on speeding up the build. I wonder if there is something we can do on the local end. It's still relatively slow.

I do wonder what the balance should be as our codespaces container is now almost 5GB!

@oleksis
Copy link
Contributor

oleksis commented Nov 17, 2023

Thank @kjaymiller, We can make the image smaller if we don't need Docker in Docker or Act

"ghcr.io/devcontainers/features/docker-in-docker": {},
"ghcr.io/devcontainers-contrib/features/act:1": {}

And instead of compiling Python add Python as a DevContainers feature

@kjaymiller
Copy link
Contributor Author

I think we don't need docker-in-docker as we're not packaging anything in our application. (If I remember act was why you needed docker-indocker)

@oleksis
Copy link
Contributor

oleksis commented Nov 17, 2023

Correct then I will update the devcontainer.json

oleksis added a commit to oleksis/blackpythondevs.com that referenced this issue Nov 17, 2023
oleksis added a commit that referenced this issue Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devcontainer enhancement New feature or request
Projects
None yet
3 participants