Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make is_static_any variables inline #34

Open
MakoEnergy opened this issue Sep 24, 2018 · 1 comment
Open

Make is_static_any variables inline #34

MakoEnergy opened this issue Sep 24, 2018 · 1 comment
Assignees
@MakoEnergy
Labels
enhancement
Milestone
1.0

Comments

@MakoEnergy
Copy link
Member

This is currently not possible because we are compiling for C++14, which does not support inline variables. When we upgrade to C++17 we should make is_static_any_v and is_static_any_decayed_v inline.
@MakoEnergy MakoEnergy self-assigned this Jan 27, 2019
MakoEnergy added a commit that referenced this issue Jan 27, 2019
@MakoEnergy
Made some template parameters inline.
b30ccf2 
Made is_static_any_v and is_static_any_decayed_v inline.  This completes #34 .
@MakoEnergy
Copy link
Member Author

After attempting to make this change, it works on all platforms except Clang on Ubuntu using the official clang package. This appears to be an issue with the compiler itself as a similar version of clang on godbolt.org worked fine. Going to shelve inline variables for now, hoping that future releases will fix this without any intervention from us.

Sqeaky pushed a commit that referenced this issue Feb 10, 2019
@MakoEnergy @Sqeaky
Feature-CPPCIUpdate (#49)
f0cd9e6 
* Updated the Jagati version and added the MacBookAir to the Jenkins setup.

* Fixed the SHA.

* Made some template parameters inline.

Made is_static_any_v and is_static_any_decayed_v inline.  This completes #34 .

* Removed tparam that Clang and MSVC hate.

* Swapped keyword order.

* Updated Travis and Appveyor files.

* Updated the Jagati version which should contain the MSVC fix.

* Run cmake twice on travis so Codecov will work.

* Updated Jagati version.

* Removed inline.

Giving up on the inline variables.
@Sqeaky Sqeaky added this to the 1.0 milestone Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MakoEnergy MakoEnergy

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@MakoEnergy @Sqeaky