Option to limit comic height #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: DailyXKCD.js README.md
Nexxic
approved these changes
Oct 26, 2016
|
Found some last bugs. Can someone else also verify, that everything works for them as intended? For example, set Then I think @Blastitt could merge this. |
Blastitt
reviewed
Nov 1, 2016
| invertColors: true | ||
| title: true | ||
| invertColors: true, | ||
| title: true, |
Blastitt
reviewed
Nov 1, 2016
| * Use this method to conveniently suspend your module when no user is present. | ||
| */ | ||
| checkUserPresence: function(notification, payload, sender) { | ||
| if (sender && notification === "USER_PRESENCE") { |
There was a problem hiding this comment.
Is there another module that can detect user presence and broadcast a notification?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the comic is larger, it scrolls downwards in a configurable interval. Since this eats a little bit of CPU, this pauses, if the module is hidden, and also listens for a
USER_PRESENCEevent to automatically stop scrolling from a possible PIR sensor.Also added options to change appearance in the config, for title and alt text, and to optionally use random comics on days, when there is no new one.