Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @playwright/test to v1.34.0 #10

Merged
merged 1 commit into from
May 20, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 14, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@playwright/test (source) 1.33.0 -> 1.34.0 age adoption passing confidence

Release Notes

Microsoft/playwright

v1.34.0

Compare Source

Highlights
  • UI Mode now shows steps, fixtures and attachments:

  • New property testProject.teardown to specify a project that needs to run after this
    and all dependent projects have finished. Teardown is useful to cleanup any resources acquired by this project.

    A common pattern would be a setup dependency with a corresponding teardown:

    // playwright.config.ts
    import { defineConfig } from '@​playwright/test';
    
    export default defineConfig({
      projects: [
        {
          name: 'setup',
          testMatch: /global.setup\.ts/,
          teardown: 'teardown',
        },
        {
          name: 'teardown',
          testMatch: /global.teardown\.ts/,
        },
        {
          name: 'chromium',
          use: devices['Desktop Chrome'],
          dependencies: ['setup'],
        },
        {
          name: 'firefox',
          use: devices['Desktop Firefox'],
          dependencies: ['setup'],
        },
        {
          name: 'webkit',
          use: devices['Desktop Safari'],
          dependencies: ['setup'],
        },
      ],
    });
  • New method expect.configure to create pre-configured expect instance with its own defaults such as timeout and soft.

    const slowExpect = expect.configure({ timeout: 10000 });
    await slowExpect(locator).toHaveText('Submit');
    
    // Always do soft assertions.
    const softExpect = expect.configure({ soft: true });
  • New options stderr and stdout in testConfig.webServer to configure output handling:

    // playwright.config.ts
    import { defineConfig } from '@​playwright/test';
    
    export default defineConfig({
      // Run your local dev server before starting the tests
      webServer: {
        command: 'npm run start',
        url: 'http://127.0.0.1:3000',
        reuseExistingServer: !process.env.CI,
        stdout: 'pipe',
        stderr: 'pipe',
      },
    });
  • New locator.and() to create a locator that matches both locators.

    const button = page.getByRole('button').and(page.getByTitle('Subscribe'));
  • New events browserContext.on('console') and browserContext.on('dialog') to subscribe to any dialogs
    and console messages from any page from the given browser context. Use the new methods consoleMessage.page()
    and dialog.page() to pin-point event source.

⚠️ Breaking changes
  • npx playwright test no longer works if you install both playwright and @playwright/test. There's no need
    to install both, since you can always import browser automation APIs from @playwright/test directly:

    // automation.ts
    import { chromium, firefox, webkit } from '@​playwright/test';
    /* ... */
  • Node.js 14 is no longer supported since it reached its end-of-life on April 30, 2023.

Browser Versions
  • Chromium 114.0.5735.26
  • Mozilla Firefox 113.0
  • WebKit 16.4

This version was also tested against the following stable channels:

  • Google Chrome 113
  • Microsoft Edge 113

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@vercel
Copy link

vercel bot commented May 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-enterprise ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2023 5:17am

yarn.lock Outdated
playwright-core@1.33.0:
version "1.33.0"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.33.0.tgz#269efe29a927cd6d144d05f3c2d2f72bd72447a1"
integrity sha512-aizyPE1Cj62vAECdph1iaMILpT0WUDCq3E6rW6I+dleSbBoGbktvJtzS6VHkZ4DKNEOG9qJpiom/ZxO+S15LAw==

pnp-webpack-plugin@^1.7.0:
version "1.7.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code patch updates the version of some dependencies, including "@playwright/test", "@types/node", and "playwright-core". The code seems fine and there are no apparent bugs or issues, but it's always a good practice to thoroughly test the updated dependencies before deploying them to production. Also, keep in mind that updating certain dependencies may require additional changes to other parts of the code. Finally, the patch does not provide any information about what prompted the need to update these dependencies, so adding a changelog or commit message explaining the reason behind the update can be helpful.

yarn.lock Outdated
version "1.33.0"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.33.0.tgz#269efe29a927cd6d144d05f3c2d2f72bd72447a1"
integrity sha512-aizyPE1Cj62vAECdph1iaMILpT0WUDCq3E6rW6I+dleSbBoGbktvJtzS6VHkZ4DKNEOG9qJpiom/ZxO+S15LAw==

playwright@^1.14.0:
version "1.32.3"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.32.3.tgz#88583167880e42ca04fa8c4cc303680f4ff457d0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code patch appears to update the versions of some packages, including "@playwright/test", "@types/node", and "playwright-core". There are no obvious bug risks, and the changes seem reasonable. However, it's always a good idea to thoroughly test the updated packages before deploying them to production. As an improvement suggestion, you may want to consider automating your code review process using tools like linters and automated testing tools.

@renovate renovate bot changed the title chore(deps): update dependency @playwright/test to v1.33.0 chore(deps): update dependency @playwright/test to v1.33.0 - autoclosed May 17, 2023
@renovate renovate bot closed this May 17, 2023
@renovate renovate bot deleted the renovate/playwright-monorepo branch May 17, 2023 15:33
@renovate renovate bot changed the title chore(deps): update dependency @playwright/test to v1.33.0 - autoclosed chore(deps): update dependency @playwright/test to v1.33.0 May 20, 2023
@renovate renovate bot reopened this May 20, 2023
@renovate renovate bot changed the title chore(deps): update dependency @playwright/test to v1.33.0 chore(deps): update dependency @playwright/test to v1.34.0 May 20, 2023
@renovate renovate bot force-pushed the renovate/playwright-monorepo branch from 7bfeadb to bb34eaa Compare May 20, 2023 05:13
version "1.34.0"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.34.0.tgz#6a8f05c657400677591ed82b6749ef7e120a152d"
integrity sha512-fMUY1+iR6kYbJF/EsOOqzBA99ZHXbw9sYPNjwA4X/oV0hVF/1aGlWYBGPVUEqxBkGANDKMziYoOdKGU5DIP5Gg==

playwright@^1.14.0:
version "1.33.0"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.33.0.tgz#88df1cffe97718ab8a02303e12c9133681ec7fab"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code patch appears to be updating dependencies for the project.

There doesn't seem to be any immediate bug risks, as the updates are within minor version ranges and the changes appear to only update dependency versions.

One potential improvement suggestion might be to add explicit version ranges for all dependencies, instead of using wildcard characters ('*'). This can help ensure that the project remains compatible with future updates to those dependencies, while still allowing some flexibility in selecting new versions.

@github-actions
Copy link

📦 Next.js Bundle Analysis for next-enterprise

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@bmstefanski bmstefanski merged commit 732f21c into main May 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant