-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @playwright/test to v1.34.0 #10
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yarn.lock
Outdated
playwright-core@1.33.0: | ||
version "1.33.0" | ||
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.33.0.tgz#269efe29a927cd6d144d05f3c2d2f72bd72447a1" | ||
integrity sha512-aizyPE1Cj62vAECdph1iaMILpT0WUDCq3E6rW6I+dleSbBoGbktvJtzS6VHkZ4DKNEOG9qJpiom/ZxO+S15LAw== | ||
|
||
pnp-webpack-plugin@^1.7.0: | ||
version "1.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code patch updates the version of some dependencies, including "@playwright/test", "@types/node", and "playwright-core". The code seems fine and there are no apparent bugs or issues, but it's always a good practice to thoroughly test the updated dependencies before deploying them to production. Also, keep in mind that updating certain dependencies may require additional changes to other parts of the code. Finally, the patch does not provide any information about what prompted the need to update these dependencies, so adding a changelog or commit message explaining the reason behind the update can be helpful.
7ae0898
to
7bfeadb
Compare
yarn.lock
Outdated
version "1.33.0" | ||
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.33.0.tgz#269efe29a927cd6d144d05f3c2d2f72bd72447a1" | ||
integrity sha512-aizyPE1Cj62vAECdph1iaMILpT0WUDCq3E6rW6I+dleSbBoGbktvJtzS6VHkZ4DKNEOG9qJpiom/ZxO+S15LAw== | ||
|
||
playwright@^1.14.0: | ||
version "1.32.3" | ||
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.32.3.tgz#88583167880e42ca04fa8c4cc303680f4ff457d0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code patch appears to update the versions of some packages, including "@playwright/test", "@types/node", and "playwright-core". There are no obvious bug risks, and the changes seem reasonable. However, it's always a good idea to thoroughly test the updated packages before deploying them to production. As an improvement suggestion, you may want to consider automating your code review process using tools like linters and automated testing tools.
7bfeadb
to
bb34eaa
Compare
version "1.34.0" | ||
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.34.0.tgz#6a8f05c657400677591ed82b6749ef7e120a152d" | ||
integrity sha512-fMUY1+iR6kYbJF/EsOOqzBA99ZHXbw9sYPNjwA4X/oV0hVF/1aGlWYBGPVUEqxBkGANDKMziYoOdKGU5DIP5Gg== | ||
|
||
playwright@^1.14.0: | ||
version "1.33.0" | ||
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.33.0.tgz#88df1cffe97718ab8a02303e12c9133681ec7fab" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code patch appears to be updating dependencies for the project.
There doesn't seem to be any immediate bug risks, as the updates are within minor version ranges and the changes appear to only update dependency versions.
One potential improvement suggestion might be to add explicit version ranges for all dependencies, instead of using wildcard characters ('*'). This can help ensure that the project remains compatible with future updates to those dependencies, while still allowing some flexibility in selecting new versions.
📦 Next.js Bundle Analysis for next-enterpriseThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This PR contains the following updates:
1.33.0
->1.34.0
Release Notes
Microsoft/playwright
v1.34.0
Compare Source
Highlights
UI Mode now shows steps, fixtures and attachments:![](https://private-user-images.githubusercontent.com/746130/239595814-1d280419-d79a-4a56-b2dc-54d631281d56.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMjc4ODIsIm5iZiI6MTcyMjEyNzU4MiwicGF0aCI6Ii83NDYxMzAvMjM5NTk1ODE0LTFkMjgwNDE5LWQ3OWEtNGE1Ni1iMmRjLTU0ZDYzMTI4MWQ1Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyOFQwMDQ2MjJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMWViNDI1M2I1ZWE5NjlmNjliMDRiMWEyMDVjY2MxY2U3MzYxZjM0YmEyZDQ2YzY3NDEyNzc3MDY2ZWRjNjE4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.0hF2KA6hnJsp6OuSw7hJujRKcXshizUpyoN_cKXf7vQ)
New property
testProject.teardown
to specify a project that needs to run after thisand all dependent projects have finished. Teardown is useful to cleanup any resources acquired by this project.
A common pattern would be a
setup
dependency with a correspondingteardown
:New method
expect.configure
to create pre-configured expect instance with its own defaults such astimeout
andsoft
.New options
stderr
andstdout
intestConfig.webServer
to configure output handling:New
locator.and()
to create a locator that matches both locators.New events
browserContext.on('console')
andbrowserContext.on('dialog')
to subscribe to any dialogsand console messages from any page from the given browser context. Use the new methods
consoleMessage.page()
and
dialog.page()
to pin-point event source.npx playwright test
no longer works if you install bothplaywright
and@playwright/test
. There's no needto install both, since you can always import browser automation APIs from
@playwright/test
directly:Node.js 14 is no longer supported since it reached its end-of-life on April 30, 2023.
Browser Versions
This version was also tested against the following stable channels:
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.