Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link dblclick segmentable #431

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

snakex64
Copy link

@snakex64 snakex64 commented Apr 13, 2024

I added a new option to make link segmentable only with double click instead of single clicks.

I also took the opportunity to add events for vertex added and removed, since there was no way of knowing the vertex changed other than cycling through all of them everytime there is a "Changed" event

@PiggyChu620
Copy link

Hello, I tried to utilize your modification through inheritance, but I don't how to "replace" the original widget and renderer with yours, I can't seem to find where it was registered in the vanilla source code.
Could you please be so kind teaching me how to do it?
Much appreciated!

@snakex64
Copy link
Author

Hello, I tried to utilize your modification through inheritance, but I don't how to "replace" the original widget and renderer with yours, I can't seem to find where it was registered in the vanilla source code. Could you please be so kind teaching me how to do it? Much appreciated!

I am not quite sure that it can be done at all! Since I have multiple PR that are not being merged I ended up just using my fork directly.

I have a "up-to-date" branch that I merged my other branches in it, and I keep it up to date with this repo. That way I have the updates and my own changes :

https://github.com/snakex64/Blazor.Diagrams/tree/up-to-date

Then, in my actual project, I just added that branche as a subrepo git and reference the csproj directly instead of the official nuget package :)

@PiggyChu620
Copy link

Hello, I tried to utilize your modification through inheritance, but I don't how to "replace" the original widget and renderer with yours, I can't seem to find where it was registered in the vanilla source code. Could you please be so kind teaching me how to do it? Much appreciated!

I am not quite sure that it can be done at all! Since I have multiple PR that are not being merged I ended up just using my fork directly.

I have a "up-to-date" branch that I merged my other branches in it, and I keep it up to date with this repo. That way I have the updates and my own changes :

https://github.com/snakex64/Blazor.Diagrams/tree/up-to-date

Then, in my actual project, I just added that branche as a subrepo git and reference the csproj directly instead of the official nuget package :)

OK, thanks.
Have you release your own NuGet package by any chance?
I don't know about legal issues and whatnot, but it'll awesome if we could install your branch directly from NuGet, because I hate to say, seems like the original creator(s) has gave up on updating this package, I mean, there are so many great minds like you helping this project grow, but the creator(s) is so relunctant to review them, let along merge them, I have to say that it's a total shame!

Btw, I have figured out how to implement your changes through inheritance (finally!): How to implement Pull Requests that is not yet being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants