Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add markdown support #8

Merged
merged 3 commits into from
May 16, 2020
Merged

add markdown support #8

merged 3 commits into from
May 16, 2020

Conversation

tarkah
Copy link
Contributor

@tarkah tarkah commented May 16, 2020

resolves #2

I gave mdcat a shot and it looks great out of the box! I'm sure you can mess around with the settings a bit, as you'd know best what terminal capabilities should be enabled and what parsing options to enable.

@LiquidityC
Copy link
Member

Looks really nice at first glance. I’ll check it out once I get to my laptop. Thanks

Copy link
Member

@LiquidityC LiquidityC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works great. Once this is merged I'll go through the helpfiles again and make them look good with this setup.

Just one minor comment.

src/help_handler.rs Outdated Show resolved Hide resolved
@tarkah
Copy link
Contributor Author

tarkah commented May 16, 2020

Good call, updated.

When text is sent to the terminal that is longer than the height of the viewport, it currently puts you at the end of the text. So when you use /help scripting you need to scroll back up to get to the top of the help page. It'd be nice if it placed the top of the page at the top of the viewport, and then required you to page down / end to the end? Maybe there can also be a visual cue at the bottom of the viewport (an ellipsis?) that indicates there is more text to scroll though as well?

@LiquidityC
Copy link
Member

Looks good. As for your suggestions regarding scrolling and indicators. Those are great and things I have in mind. That's why there is a top-bar and a separator. Figure I can use those for what you are asking. Just push the issues on the stack and I'll pick them up as I go along. Or you can pick them up yourself 😄

@LiquidityC LiquidityC merged commit 1a31f34 into Blightmud:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add markdown support
2 participants