Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FindAndCountAll method and add tests #32

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Add FindAndCountAll method and add tests #32

merged 1 commit into from
Oct 23, 2017

Conversation

TerryMooreII
Copy link
Contributor

Here is the FindAndCountAll method and tests

@TerryMooreII TerryMooreII mentioned this pull request Oct 20, 2017
Closed
@LoveAndCoding LoveAndCoding self-requested a review October 23, 2017 17:56
@LoveAndCoding LoveAndCoding self-assigned this Oct 23, 2017
@LoveAndCoding LoveAndCoding merged commit 0c65238 into BlinkUX:master Oct 23, 2017
@LoveAndCoding
Copy link
Contributor

Thank you so much for your work! This is a very clean solution and the tests and documentation for it are great.

@TerryMooreII
Copy link
Contributor Author

TerryMooreII commented Oct 24, 2017 •
edited
Loading

@ktsashes Any chance you can release the next version of the npm package? I need this function asap. Thanks!

@LoveAndCoding LoveAndCoding added this to the v0.10.0 milestone Oct 24, 2017
@LoveAndCoding
Copy link
Contributor

I just pushed v0.10.0 out, and it includes this change

@TerryMooreII TerryMooreII deleted the findAndCountAll branch October 25, 2017 02:27
@TerryMooreII
Copy link
Contributor Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveAndCoding LoveAndCoding LoveAndCoding approved these changes

Assignees

@LoveAndCoding LoveAndCoding

Labels
feature: Models
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TerryMooreII @LoveAndCoding