Update librdkafka from 1.7.0 -> 1.8.2 #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iAlex97 fyi since you were interested in this |
|
@iradul Could you review this when you have the chance. Thank you |
|
It looks good. Thank you @GaryWilber |
|
@iradul sorry to be bothering, but can you also do a npm release like you did with 1.7.0? |
CharlesSwiftConnect
added a commit
to SwiftCTRL/node-rdkafka
that referenced
this pull request
May 19, 2022
Co-authored-by: Gary Wilber <41303831+GaryWilber@users.noreply.github.com>
henrinormak
pushed a commit
to 6fold/node-rdkafka
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same story as last time. All the unit & e2e tests are passing for me besides the deleteTopic one, which is failing due to me testing on windows & known kafka bugs (1, 2)
The largest change in this update is related to the nuget package. v1.8.0 introduced some packaging changes, which required changes to the
windows-install.pyscript.Changes:
windows-install.pyscript to support the new packaging formatlibrdkafka-defs-generator.jsscript for better CRLF line ending support