Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update librdkafka from 1.6.1 -> 1.7.0 #915

Merged
merged 5 commits into from
Nov 21, 2021

Conversation

GaryWilber
Copy link
Collaborator

@GaryWilber GaryWilber commented Sep 8, 2021

I created this PR based on #879.

All the unit & e2e tests are passing for me besides the deleteTopic one, which is failing due to me testing on windows & known kafka bugs (1, 2)

Other changes:

  • Added an Updating librdkafka version section to the readme to help future contributors that are interested in updating the librdkafka version. Please let me know if I missed any steps.
  • Updated librdkafka-defs-generator.js script to support CRLF line endings too

@GaryWilber
Copy link
Collaborator Author

@iradul Could you review this when you get a chance? Thanks!

Also librdkafka 1.8 recently came out. I think it's still fine to move to 1.7 first. I can create another PR afterwards to move to 1.8.

@iradul
Copy link
Collaborator

iradul commented Oct 31, 2021

Thanks for the PR.

README.md Outdated Show resolved Hide resolved
@GaryWilber
Copy link
Collaborator Author

@iradul Would you be able to review this again and complete it if it looks good? I'm hoping this could get in & released soon. Afterwards I can start work on consuming v1.8.2, which contains some consumer related fixes that my service is very interested in.

@iAlex97
Copy link

iAlex97 commented Nov 15, 2021

Following up on this, we're in exactly the same situation as @GaryWilber 😄

I have actually forked a branch from this just so we can test if a build running with kafka 1.8.2 would solve some problems, but I didn't want to steal the credit for it.

@iradul
Copy link
Collaborator

iradul commented Nov 21, 2021

Thank you @GaryWilber ! I added just a tiny fix to the CONTRIBUTING.md file.

@iradul iradul merged commit f092160 into Blizzard:master Nov 21, 2021
@GaryWilber GaryWilber deleted the librdkafka_1.7.0 branch November 22, 2021 18:38
henrinormak pushed a commit to 6fold/node-rdkafka that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants