Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4273 azurehound backoff retry #74

Merged
merged 18 commits into from
Apr 17, 2024
Merged

Conversation

benwaples
Copy link
Contributor

@benwaples benwaples commented Apr 1, 2024

BED-4273

Adds backoff/retry logic to force closed connection and 502 bad gateway responses. Removes timeout on ingest requests

Implementation

added checks when making requests to azure and bhe api.

Testing

Added TestClosedConnection to test the retry logic from a force-closed connection.

@benwaples benwaples self-assigned this Apr 2, 2024
@benwaples benwaples marked this pull request as ready for review April 2, 2024 22:45
Copy link
Contributor

@sircodemane sircodemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sircodemane
Copy link
Contributor

new changes look good :salute:

@benwaples benwaples merged commit a3bef02 into main Apr 17, 2024
9 checks passed
@benwaples benwaples deleted the BED-4273--azurehound-backoff-retry branch April 17, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants