Adding #51 to changelog #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone please merge this! |
| @@ -1205,6 +1205,8 @@ Changelog | |||
|
|
|||
| * v0.10.1 - Not released yet | |||
|
|
|||
| * Unpinn python-blosc (#51) | |||
There was a problem hiding this comment.
Unpin can be used as a verb if you want, but I assume that you would want to use past tense in release notes/change log: unpinned.
There was a problem hiding this comment.
It's English, man! Just make it up as you go along!! :)
There was a problem hiding this comment.
The changelog uses present-tense until now, let's stay consistent?
There was a problem hiding this comment.
Oops, I should have picked up on that!
|
I fixored it, please merge. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was missing.