Fetch Content Superbuild for zlib-ng #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise: - we cannot use it in our shared lib - downstream consumers will not be able to use it in shared libs, even if c-blosc is build as static Not using -fPIC is a corner-case and should be addressed with proper external dependencies instead of a superbuild (marginal performance gains).
We will need to export the Zlib-NG libs to the build tree, because upstream does not do it yet (work-around). Additionally, we want to install zlib, because users might need it in case they pick up c-blosc2 as a static lib.
This was referenced Aug 20, 2023
ax3l
force-pushed
the
fetchcontent-zlib-ng-updates
branch
from
b5c0e3f
to
400d50b
Compare
ax3l
force-pushed
the
fetchcontent-zlib-ng-updates
branch
from
5abd1cf
to
625f87b
Compare
|
Hey @ax3l this is really cool! It is the first time that we are using |
|
Hi @FrancescAlted, yes it's fun! 🎉 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional logic needed to make superbuilds with fetch-content on recent versions of zlib-ng work in #544.